Avoid importing submodules sharing names with standard library modules #2702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
commented
Mar 9, 2025
| sys.path.insert(0, resources.find("data")) | ||
| try: | ||
| with pytest.raises(ImportError): | ||
| spec._find_spec_with_path( |
There was a problem hiding this comment.
I would have preferred to find a public interface to test, but after almost an hour of fiddling I threw in the towel.
DanielNoord
approved these changes
Mar 9, 2025
Pierre-Sassoulas
approved these changes
Mar 9, 2025
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Mar 9, 2025
#2702) (#2703) (cherry picked from commit 9f8faeb) Co-authored-by: Jacob Walls <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #2684
Avoid importing
user_module.std_lib_nameif we can help it.