Remove str instance in model of BaseException.attrs #1749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not require first exception argument to be a string. The word "usually" does not imply an obligation. https://docs.python.org/3/library/exceptions.html#BaseException.args
This was referenced Aug 23, 2022
Pull Request Test Coverage Report for Build 2910400344
💛 - Coveralls |
3 tasks
Pierre-Sassoulas
approved these changes
Aug 23, 2022
|
Last merge request before the release, right ? |
|
@Pierre-Sassoulas Yeah! |
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Aug 23, 2022
Do not require first exception argument to be a string. The word "usually" does not imply an obligation. https://docs.python.org/3/library/exceptions.html#BaseException.args Co-authored-by: Nicholas Guriev <[email protected]>
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Aug 23, 2022
Do not require first exception argument to be a string. The word "usually" does not imply an obligation. https://docs.python.org/3/library/exceptions.html#BaseException.args Co-authored-by: Nicholas Guriev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1722 as I didn't have commit rights on the branch.
Original post:
Do not require first exception argument to be a string. The word "usually" does not imply an obligation.
https://docs.python.org/3/library/exceptions.html#BaseException.args
Steps
Description
Type of Changes
Related Issue
Refs: pylint-dev/pylint#7233