-
-
Notifications
You must be signed in to change notification settings - Fork 305
Closed
Labels
MaintenanceDiscussion or action around maintaining astroid or the dev workflowDiscussion or action around maintaining astroid or the dev workflowtopic-performance
Description
Problem
I stumbled upon this video which explains problems with using lru_cache
on methods as it leaks self
. I haven't watched the full video yet but watched the previous video and saw the PR at pytest
here: pytest-dev/pytest#9148
This is something we're doing ourselves as well and could be a potential source of memory leaks and other problems. I think this warrants an investigation and probably a refactor.
/CC @keichi As your PR #1242 also decorates methods, they might also be affected by this. Note that I haven't watched the full video yet so I don't know the exact implications but this is worthwhile to investigate.
Pierre-Sassoulas
Metadata
Metadata
Assignees
Labels
MaintenanceDiscussion or action around maintaining astroid or the dev workflowDiscussion or action around maintaining astroid or the dev workflowtopic-performance