Skip to content

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Apr 14, 2024

Implement a https://github.com/FitSNAP/FitSNAP based interface to calculate SNAP and ACE descriptors for the whole simulation cell and their directional derivatives for fitting machine learned potentials.

@liamhuber
Copy link
Member

Mutable defaults are not recommended.

@jan-janssen jan-janssen marked this pull request as draft May 23, 2024 16:35
Copy link

coderabbitai bot commented Jul 18, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fitsnap

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@raynol-dsouza
Copy link
Contributor

Hi @jan-janssen, just wanted to ask if this branch is good to go or still requires some work. I am in need of a standalone descriptor evaluator (without explicitly running LAMMPS or another calculator) for my current project and was referred to this branch by @HaithamGaafer.

@jan-janssen
Copy link
Member Author

@raynol-dsouza It still needs a bit of work, in terms of writing tests and fixing the continuous integration. But I think it should be possible reasonable effort.

@jan-janssen
Copy link
Member Author

I am in need of a standalone descriptor evaluator (without explicitly running LAMMPS or another calculator) for my current project and was referred to this branch by @HaithamGaafer.

This runs fitsnap which internally runs lammps, it is just a more efficient interface. Is this what you need?

@raynol-dsouza
Copy link
Contributor

raynol-dsouza commented Oct 8, 2025

This runs fitsnap which internally runs lammps, it is just a more efficient interface. Is this what you need?

I am aware of the internal usage of lammps in fitsnap. I know that lammps can compute SNAP (bispectrum) descriptors from just the input parameters for a structure, but for computing ACE descriptors, it requires in addition a coefficients file.

Ideally, I would like to have a means of computing ACE descriptors without input coefficients just like SNAP (where the coefficients are computed internally in the compute). For the time being though, if the interface here does that for me, then it would be a good starting point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants