-
Notifications
You must be signed in to change notification settings - Fork 1
Implement Fitsnap interface for SNAP and ACE #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Mutable defaults are not recommended. |
# Conflicts: # pyproject.toml
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
for more information, see https://pre-commit.ci
Hi @jan-janssen, just wanted to ask if this branch is good to go or still requires some work. I am in need of a standalone descriptor evaluator (without explicitly running LAMMPS or another calculator) for my current project and was referred to this branch by @HaithamGaafer. |
@raynol-dsouza It still needs a bit of work, in terms of writing tests and fixing the continuous integration. But I think it should be possible reasonable effort. |
This runs |
I am aware of the internal usage of Ideally, I would like to have a means of computing ACE descriptors without input coefficients just like SNAP (where the coefficients are computed internally in the |
Implement a https://github.com/FitSNAP/FitSNAP based interface to calculate SNAP and ACE descriptors for the whole simulation cell and their directional derivatives for fitting machine learned potentials.