Remove default terminate function

[jan-janssen]

Summary by CodeRabbit

• Refactor
  • Updated the file executor creation process to accept an optional termination function.
  • Simplified internal logic related to subprocess termination handling.

[coderabbitai]

Walkthrough

The changes remove conditional logic related to subprocess termination in the FileTaskScheduler constructor, update the create_file_executor function to accept an optional terminate_function parameter, and ensure this parameter is passed to FileTaskScheduler. The import of terminate_subprocess was also removed.

Changes

File(s)	Change Summary
executorlib/task_scheduler/file/task_scheduler.py	Removed terminate_subprocess import, deleted conditional assignment for terminate_function, updated create_file_executor signature to accept terminate_function, and modified its call to FileTaskScheduler.

Poem

A hop and a skip, the code is now neat,
No more subprocess checks in this rabbit’s retreat.
With cleaner signatures, the tasks are in line,
Optional terminators—how simply divine!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bd45608 and eeb38a2.

📒 Files selected for processing (1)

• executorlib/task_scheduler/file/task_scheduler.py (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)

• GitHub Check: unittest_openmpi (ubuntu-latest, 3.11)
• GitHub Check: unittest_flux_mpich
• GitHub Check: unittest_openmpi (macos-latest, 3.13)
• GitHub Check: notebooks_integration
• GitHub Check: unittest_openmpi (ubuntu-latest, 3.13)
• GitHub Check: unittest_openmpi (ubuntu-latest, 3.12)
• GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-mpich.yml)
• GitHub Check: notebooks
• GitHub Check: unittest_flux_openmpi
• GitHub Check: unittest_win
• GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-openmpi.yml)
• GitHub Check: minimal
• GitHub Check: pip_check
• GitHub Check: unittest_mpich (macos-latest, 3.13)
• GitHub Check: unittest_mpich (ubuntu-latest, 3.12)
• GitHub Check: unittest_old
• GitHub Check: unittest_mpich (ubuntu-latest, 3.11)
• GitHub Check: unittest_mpich (ubuntu-latest, 3.13)

🔇 Additional comments (2)

executorlib/task_scheduler/file/task_scheduler.py (2)

117-117: LGTM! Parameter passing is correct.

The terminate_function parameter is properly passed through to the FileTaskScheduler constructor, maintaining consistency with the function signature change.

---

93-93: No breaking changes from adding terminate_function to create_file_executor

All existing calls to create_file_executor use keyword arguments (or no arguments) and are unaffected by the new, default-valued terminate_function parameter:

• tests/test_cache_fileexecutor_serial.py (calls with no args or only keyword args)
• executorlib/executor/slurm.py (all parameters passed as named arguments)
• executorlib/executor/flux.py (all parameters passed as named arguments)

Since the new parameter is optional and callers already use keywords, no updates are required.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.90%. Comparing base (bd45608) to head (eeb38a2).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
- Coverage   96.90%   96.90%   -0.01%     
==========================================
  Files          29       29              
  Lines        1325     1323       -2     
==========================================
- Hits         1284     1282       -2     
  Misses         41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.