Skip to content

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Jun 6, 2025

PR to hopefully fix #3468

@ankith26 ankith26 requested a review from a team as a code owner June 6, 2025 10:21
@oddbookworm oddbookworm added this to the 2.5.5 milestone Jun 6, 2025
@oddbookworm
Copy link
Member

#3353
We'll regress this if we merge this as-is. Can we try to fix the encoding issue instead potentially?

@ankith26
Copy link
Member Author

ankith26 commented Jun 6, 2025

There are a lot of files and we would have to trial and error manually. The first suspect is all korean files. I don't have a mac so someone else would need to do this.

@oddbookworm
Copy link
Member

It has to be someone with a developer license from apple I think, I tried with my mac, but it worked for me (but the sign was only valid on my own mac)

@ankith26
Copy link
Member Author

ankith26 commented Jun 6, 2025

I think for now we have a good compromise - only the korean tuts are excluded. Anyone who wants the english/spanish tuts can still access it from the wheel. The korean tuts should continue to be available on pyga.me so I think excluding it in the wheels doesn't really cause problems to anyone.

@davidfokkema has confirmed that the current state of this PR fixes the issue (thanks again for all the testing!)

@ankith26 ankith26 changed the title Re exclude tutorials in release wheels and run important CI everytime Re exclude korean tutorials in release wheels and run important CI everytime Jun 6, 2025
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We'll have to keep in mind to exclude any non-ASCII docs names in the future

@Starbuck5 Starbuck5 added the macOS label Jun 7, 2025
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ankith!

@Starbuck5 Starbuck5 merged commit 810aa48 into main Jun 7, 2025
11 checks passed
@ankith26 ankith26 deleted the ankith26-exclude-tuts branch June 8, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notarization fails for pygame-ce 2.5.4, but succeeds for 2.5.3
3 participants