Skip to content

adding 'open_groups_as_dict' fucntion to open any zarr file containing nested groups #9431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

adding 'open_groups_as_dict' fucntion to open any zarr file containing nested groups #9431

wants to merge 4 commits into from

Conversation

aladinor
Copy link
Contributor

@aladinor aladinor commented Sep 4, 2024 •
edited
Loading

aladinor
aladinor commented Sep 4, 2024
View reviewed changes
Copy link
Contributor Author

@aladinor aladinor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomNicholas, this is what I was talking about today. Any suggestion on what might be happening?

@TomNicholas
Copy link
Member

Wait hang on, is this now a duplicate of the PR @eni-awowale just opened in #9469?

@TomNicholas TomNicholas added topic-zarr Related to zarr storage library topic-DataTree Related to the implementation of a DataTree class topic-backends labels Sep 10, 2024
@eni-awowale
Copy link
Collaborator

eni-awowale commented Sep 10, 2024 •
edited
Loading

Lol @TomNicholas I think everything but the tests I added is the same 💀

EDIT:
Wait actually it looks like they're a couple other differences but yeah it's the same idea.

@TomNicholas
Copy link
Member

Agh sorry for the duplicated work here @aladinor - that's my bad!

@eni-awowale has got a lot further with testing in her PR so we'll probably end up merging that and closing this, once any differences have been looked at.

@aladinor
Copy link
Contributor Author

Closing this as is solved by #9469

@aladinor aladinor closed this Sep 24, 2024
@aladinor aladinor deleted the group-dicts-dtree branch October 12, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic-backends topic-DataTree Related to the implementation of a DataTree class topic-zarr Related to zarr storage library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

open_groups function to open any zarr file containing nested groups
3 participants
@aladinor @TomNicholas @eni-awowale