Skip to content

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Apr 24, 2024

  1. Now that numba supports 3.12.
  2. Disabled pint on the main environment since it doesn't work. Pint is still installed in the all-but-dask env, which is still runs python 3.11 for this reason.

Now that numba supports 3.12.
@dcherian dcherian added the Automation Github bots, testing workflows, release automation label Apr 24, 2024
@dcherian dcherian added run-upstream Run upstream CI run-slow-hypothesis Run slow hypothesis tests labels Apr 25, 2024
@dcherian dcherian requested a review from keewis April 25, 2024 15:00
@dcherian
Copy link
Contributor Author

@Illviljan are you able to take a look at these mypy failures?

If not, we can bump the mypy test python version later.

xarray/tests/test_typed_ops.py: note: In function "test_dataset_typed_ops":
xarray/tests/test_typed_ops.py:139: error: Argument 1 to "_test" has incompatible type "Variable"; expected "Dataset"  [arg-type]
xarray/tests/test_typed_ops.py:140: error: Argument 1 to "_test" has incompatible type "DataArray"; expected "Dataset"  [arg-type]
xarray/tests/test_typed_ops.py:151: error: Argument 1 to "_test" has incompatible type "Variable"; expected "Dataset"  [arg-type]
xarray/tests/test_typed_ops.py:152: error: Argument 1 to "_test" has incompatible type "DataArray"; expected "Dataset"  [arg-type]
xarray/tests/test_typed_ops.py:163: error: Argument 1 to "_test" has incompatible type "Variable"; expected "Dataset"  [arg-type]
xarray/tests/test_typed_ops.py:164: error: Argument 1 to "_test" has incompatible type "DataArray"; expected "Dataset"  [arg-type]

Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, at least as far as the non-typing changes go.

The reason pint fails is still the same as in #8605: pint didn't define dtype explicitly, so is_duck_array does not recognize it as a duck array on python>=3.12. I guess I should ask for a release of pint...

@dcherian dcherian merged commit fa8e90c into pydata:main Apr 29, 2024
@dcherian dcherian deleted the minimize-ci branch April 29, 2024 16:21
@dcherian
Copy link
Contributor Author

Merging since this really reduces our CI times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Automation Github bots, testing workflows, release automation run-slow-hypothesis Run slow hypothesis tests run-upstream Run upstream CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants