Skip to content

Allow selecting variables using a list with mixed data types #5394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2021
Merged

Allow selecting variables using a list with mixed data types #5394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d367db
force object dtype in asarray
malmans2 May 28, 2021
ee83399
remove asarray
malmans2 May 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion xarray/core/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1485,7 +1485,7 @@ def __getitem__(self, key):
if hashable(key):
return self._construct_dataarray(key)
else:
return self._copy_listed(np.asarray(key))
return self._copy_listed(key)

def __setitem__(self, key: Union[Hashable, List[Hashable], Mapping], value) -> None:
"""Add an array to this dataset.
Expand Down
5 changes: 5 additions & 0 deletions xarray/tests/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3305,6 +3305,11 @@ def test_getitem_hashable(self):
with pytest.raises(KeyError, match=r"('var1', 'var2')"):
data[("var1", "var2")]

def test_getitem_multiple_dtype(self):
keys = ["foo", 1]
dataset = Dataset({key: ("dim0", range(1)) for key in keys})
assert_identical(dataset, dataset[keys])

def test_virtual_variables_default_coords(self):
dataset = Dataset({"foo": ("x", range(10))})
expected = DataArray(range(10), dims="x", name="x")
Expand Down