-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Order coords to match dims in repr #10778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Illviljan
reviewed
Sep 26, 2025
Illviljan
approved these changes
Oct 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There were quite a few fixes needed in our tests so I guess it might be noticeable for others.
But they could use something like https://github.com/max-sixty/pytest-accept to fix their reprs.
weiji14
added a commit
to GenericMappingTools/pygmt
that referenced
this pull request
Oct 8, 2025
Specifically on `_GMT_IMAGE.to_xarray` and `GMTBackendEntrypoint`, due to changes in xarray=2025.10.0 from repr changes to the coords ordering, xref pydata/xarray#10778. Also removed ellipsis and added the size of the DataArray and coordinates in kB.
6 tasks
weiji14
added a commit
to GenericMappingTools/pygmt
that referenced
this pull request
Oct 9, 2025
…pr (#4145) Specifically on `_GMT_IMAGE.to_xarray` and `GMTBackendEntrypoint`, due to changes in xarray=2025.10.1 from repr changes to the coords ordering, xref pydata/xarray#10778. Also removed ellipsis and added the size of the DataArray and coordinates in kB. --------- Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo
From #712:
From #4515:
whats-new.rst
api.rst