Skip to content

Conversation

@mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented May 19, 2025

No description provided.

@mtsokol mtsokol requested a review from hameerabbasi May 19, 2025 10:00
@mtsokol mtsokol self-assigned this May 19, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 19, 2025

CodSpeed Performance Report

Merging #872 will degrade performances by 21.68%

Comparing ms/bump-finch-tensor (66b3208) with main (de328a1)

Summary

❌ 2 regressions
✅ 338 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_index_fancy[side=100-rank=1-format='coo'] 1 ms 1.3 ms -21.68%
test_index_slice[side=100-rank=2-format='gcxs'] 2.5 ms 3.1 ms -18.67%

@mtsokol
Copy link
Collaborator Author

mtsokol commented May 19, 2025

@hameerabbasi I think we can merge it?

@hameerabbasi hameerabbasi merged commit 79c1a17 into main May 19, 2025
16 of 19 checks passed
@hameerabbasi hameerabbasi deleted the ms/bump-finch-tensor branch May 19, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants