-
-
Notifications
You must be signed in to change notification settings - Fork 132
test: Converting tensordot benchmark to run with CodSpeed #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides the one comment; thanks @DeaMariaLeon!
Seems like an out of memory error again... I would reduce the scope of the PyTest fixtures to |
CodSpeed Performance ReportMerging #761 will not alter performanceComparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @DeaMariaLeon!
What type of PR is this? (check all applicable)
Related issues
Checklist
Please explain your changes below.
The sides of the tensors are small, but when using 200, 500, 1000 (please see lines 17 - 19) the tests took a long time locally. More than 25 min. But I don't know for how much longer because my machine never finished the tests (so I Ctrl-break to stop). Please let me know if you have an idea of the sizes I should use.