Skip to content

test: Converting tensordot benchmark to run with CodSpeed #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 30, 2024

Conversation

DeaMariaLeon
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • πŸͺ„ Feature
  • 🐞 Bug Fix
  • πŸ”§ Optimization
  • πŸ“š Documentation
  • πŸ§ͺ Test
  • πŸ› οΈ Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide
  • Tests added
  • Documented the changes

Please explain your changes below.

The sides of the tensors are small, but when using 200, 500, 1000 (please see lines 17 - 19) the tests took a long time locally. More than 25 min. But I don't know for how much longer because my machine never finished the tests (so I Ctrl-break to stop). Please let me know if you have an idea of the sizes I should use.

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the one comment; thanks @DeaMariaLeon!

@hameerabbasi
Copy link
Collaborator

Seems like an out of memory error again... I would reduce the scope of the PyTest fixtures to test, or maybe module at best.

Copy link

codspeed-hq bot commented Aug 30, 2024

CodSpeed Performance Report

Merging #761 will not alter performance

Comparing DeaMariaLeon:bench (245e0ba) with main (1c56a0b)

Summary

βœ… 244 untouched benchmarks

πŸ†• 96 new benchmarks

Benchmarks breakdown

Benchmark main DeaMariaLeon:bench Change
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=10-n=10-p=20-q=10-COO] N/A 1.8 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=10-n=10-p=20-q=10-ndarray] N/A 1.5 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=10-n=10-p=20-q=50-COO] N/A 2.2 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=10-n=10-p=20-q=50-ndarray] N/A 1.7 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=10-n=10-p=50-q=10-COO] N/A 2 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=10-n=10-p=50-q=10-ndarray] N/A 1.6 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=10-n=10-p=50-q=50-COO] N/A 2.9 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=10-n=10-p=50-q=50-ndarray] N/A 2.3 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=10-n=20-p=20-q=10-COO] N/A 1.9 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=10-n=20-p=20-q=10-ndarray] N/A 1.5 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=10-n=20-p=20-q=50-COO] N/A 2.6 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=10-n=20-p=20-q=50-ndarray] N/A 2.1 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=10-n=20-p=50-q=10-COO] N/A 2.2 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=10-n=20-p=50-q=10-ndarray] N/A 1.7 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=10-n=20-p=50-q=50-COO] N/A 4 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=10-n=20-p=50-q=50-ndarray] N/A 3.2 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=50-n=10-p=20-q=10-COO] N/A 2.1 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=50-n=10-p=20-q=10-ndarray] N/A 1.7 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=50-n=10-p=20-q=50-COO] N/A 3.7 ms N/A
πŸ†• test_tensordot[left_index=1-right_index=1-left_format='coo'-right_format='dense'-m=50-n=10-p=20-q=50-ndarray] N/A 3.2 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DeaMariaLeon!

@hameerabbasi hameerabbasi merged commit fb0affe into pydata:main Aug 30, 2024
18 of 19 checks passed
@DeaMariaLeon DeaMariaLeon deleted the bench branch August 30, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants