Skip to content

FIX: new CSS approach to navbar-covers-target-anchor problem #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2021
Merged

FIX: new CSS approach to navbar-covers-target-anchor problem #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9c89e8
use scroll-padding-top to keep anchor targets visible
drammock Feb 15, 2021
948eec7
fix merge conflicts
drammock Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ndex.361b90cc13c3b373e3e2df043d87d1bd.css → ...ndex.0e366ba14472447708f75ccb7d8f24a3.css
View file
Open in desktop

Large diffs are not rendered by default.

0 ...e/static/js/index.4bc14ce28f4cf826ca84.js → ...e/static/js/index.9ab83e9ee01d4093105a.js
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions pydata_sphinx_theme/static/webpack-macros.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@

{% macro head_pre_bootstrap() %}
<link href="{{ pathto('_static/css/theme.css', 1) }}" rel="stylesheet" />
<link href="{{ pathto('_static/css/index.361b90cc13c3b373e3e2df043d87d1bd.css', 1) }}" rel="stylesheet" />
<link href="{{ pathto('_static/css/index.0e366ba14472447708f75ccb7d8f24a3.css', 1) }}" rel="stylesheet" />
{% endmacro %}

{% macro head_js_preload() %}
<link rel="preload" as="script" href="{{ pathto('_static/js/index.4bc14ce28f4cf826ca84.js', 1) }}">
<link rel="preload" as="script" href="{{ pathto('_static/js/index.9ab83e9ee01d4093105a.js', 1) }}">
{% endmacro %}

{% macro body_post() %}
<script src="{{ pathto('_static/js/index.4bc14ce28f4cf826ca84.js', 1) }}"></script>
<script src="{{ pathto('_static/js/index.9ab83e9ee01d4093105a.js', 1) }}"></script>
{% endmacro %}
13 changes: 1 addition & 12 deletions src/scss/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
html {
font-size: var(--font-size-base);
scroll-padding-top: calc(var(--header-height) + 12px);
}

body {
Expand Down Expand Up @@ -108,15 +109,3 @@ pre {
border: 1px solid rgb(201, 201, 201);
box-shadow: 1px 1px 1px #d8d8d8;
}

// offsetting html elements with anchor attached to adjust for fixed header
:target {
&::before {
// offsetting html anchor titles to adjust for fixed header
display: block;
content: '';
height: var(--header-height);
margin: calc(-1 * var(--header-height)) 0 0;
background-color: white;
}
}