Skip to content

Allow for a gitlab social media button #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2020
Merged

Allow for a gitlab social media button #289

merged 1 commit into from
Dec 6, 2020

Conversation

pgjones
Copy link
Contributor

@pgjones pgjones commented Dec 4, 2020

Alongside the existing github option.

@pgjones
Allow for a gitlab social media button
3cb0d1a 
Alongside the existing github option.
@choldgraf choldgraf merged commit 938aa3d into pydata:master Dec 6, 2020
@choldgraf
Copy link
Collaborator

LGTM - thanks very much 👍

@pgjones
Copy link
Contributor Author

pgjones commented Dec 6, 2020

Thanks!

@derrickmaestas
Copy link

derrickmaestas commented Dec 14, 2020 •
edited
Loading

We use GitLab at my company, I have overriden the navbar to include a Gitlab logo, so was excited to see this.

fa-gitlab-square is not a FontAwesome logo. Only the standard GitLab logo is included.

This was referenced Mar 12, 2021
Closed
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgjones @choldgraf @derrickmaestas