Import Bootstrap after importing our variable overrides #2066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might want to create a follow up issue to re-evaluate whether or not we need to bring our current set of breakpoints more up to date. |
|
I wonder if there's a way to add a regression test to this |
|
Good catch @gabalafou ! I missed this as we were, for some reason, importing Bootstrap variables twice, so thanks for figuring this out. As for regression testing 🤔 I cannot think of a good way unless we add some visual checks/inspection. Since you had identified that the dropdown hover colour was incorrect maybe we can add a Playwright test checking that the hover colour is correct per our design system? |
trallard
approved these changes
Dec 4, 2024
|
I am going to merge this, and we can discuss and work on tests later on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the effects of the variables defined in variables/_bootstrap.scss
This fixes #2022 and also fixes another issue that I had noticed when clicking links in the "More" dropdown. Screenshots: