Skip to content

Conversation

trallard
Copy link
Collaborator

We currently use node.js 16 for PST, which has long been out of LTS.

This PR bumps node to v22, which is the Current version and will soon be moved to Active.

Ref: https://nodejs.org/en/about/previous-releases

@trallard trallard added the tag: dependencies Pull requests that update a dependencies or that is related to PST dependencies label Sep 27, 2024
@trallard trallard requested a review from gabalafou September 27, 2024 13:59
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@trallard
Copy link
Collaborator Author

Note this PR needs rebasing against main as I opened it before the fix to add FA to our build assets. Will do next week.

Copy link
Collaborator

@Carreau Carreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want this pre 0.16.0 ?

@trallard
Copy link
Collaborator Author

trallard commented Oct 1, 2024

@Carreau since I already cut the pre-release I am tempted to have this in the upcoming release.

WDYT @drammock?

@drammock
Copy link
Member

drammock commented Oct 1, 2024

Personally I would wait

@trallard
Copy link
Collaborator Author

trallard commented Oct 1, 2024

So we are in agreement then and will leave it until 0.16.1 or so.
Will add a do not merge label to be on the safe side

@trallard trallard added the DO NOT MERGE There is something blocking merging this PR label Oct 1, 2024
@Carreau
Copy link
Collaborator

Carreau commented Oct 1, 2024

May I suggest we may also use milestones for what for which version ?

@Carreau Carreau added this to the 0.16.1 milestone Oct 1, 2024
@Carreau
Copy link
Collaborator

Carreau commented Oct 1, 2024

May I suggest we may also use milestones for what for which version ?

Made a 0.16.1 it's always easy to remove a milestone.

@trallard trallard removed the DO NOT MERGE There is something blocking merging this PR label Oct 22, 2024
@trallard
Copy link
Collaborator Author

Now that the release has been made, I have removed the DO-NOT-MERGE label. Shall we merge or should we wait a couple of days in case we need to do a patch release? cc @drammock @Carreau

@trallard trallard changed the title MAINT - Bump node version MAINT - Bump node version (22.x) Oct 22, 2024
@drammock
Copy link
Member

Now that the release has been made, I have removed the DO-NOT-MERGE label. Shall we merge or should we wait a couple of days in case we need to do a patch release? cc @drammock @Carreau

I don't really expect this to break anything, but still I think it would be wise to be cautious, and wait a few days.

@Carreau
Copy link
Collaborator

Carreau commented Nov 4, 2024

A few days, have now been a few weeks, merging.

@Carreau Carreau merged commit 7db16bc into pydata:main Nov 4, 2024
25 checks passed
@trallard trallard deleted the trallard/upgrade-node branch November 19, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tag: dependencies Pull requests that update a dependencies or that is related to PST dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants