-
Notifications
You must be signed in to change notification settings - Fork 341
Improve full width usage of content. #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve full width usage of content. #141
Conversation
Full width until width breakpoint 1300px
I think that this might address my issue #140 as well 👍 |
Indeed, what you described in your concerns and solution is what can be done by extending the breakpoint variables. Do you think the breakpoint at width 1300px is good for your screen setup? |
I think 1300 is reasonable? Maybe 1350? For some reason my brain thinks of "actually big screens" as starting at 1400. Maybe there is a CSS standard for this even if it's not in official bootstrap? |
@hoetmaaiers Thanks a lot, this looks good! (exactly what I had in mind ;)) I think the breakpoint of 1300 is OK for the current layout, in the sense that at 1300px it uses the same max-width for the main content as on wider screens. But, there are still some things that could use more space by default:
But let's keep those for another issue/PR. @hoetmaaiers this is ready to be merged? |
I’d be a fan of content max width closer to 750 or 800. Usually I just do whatever google does given that they have way more UI/UX budget than I do haha. Also fine with it to be in another pr. |
I updated the xl breakpoint to 1400 px. Which enlarges the body content to 749. Also the TOC sidebar is again a bit wider. From my part this is ready to be merged. |
it looks good to me 👍 |
Looks good, thanks for the update! |
woo thanks again for the nice improvement @hoetmaaiers 🎉 |
This PR tries to improve the feedback from @jorisvandenbossche about his full width experience in PR #134. The content is positioned fluidly until breakpoint width 1300px. Above this breakpoint the content is centered.
By reconfiguring the breakpoint we can play with this very easily: https://github.com/pandas-dev/pydata-sphinx-theme/compare/master...hoetmaaiers:feature/full-width-improvements?expand=1#diff-e3d1d830790a12807fb397358c25d549R7.
After using the breakpoint mixin, these variables should work even better.
Feedback from Joris: