Skip to content

Improve full width usage of content. #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hoetmaaiers
Copy link
Collaborator

This PR tries to improve the feedback from @jorisvandenbossche about his full width experience in PR #134. The content is positioned fluidly until breakpoint width 1300px. Above this breakpoint the content is centered.

By reconfiguring the breakpoint we can play with this very easily: https://github.com/pandas-dev/pydata-sphinx-theme/compare/master...hoetmaaiers:feature/full-width-improvements?expand=1#diff-e3d1d830790a12807fb397358c25d549R7.

After using the breakpoint mixin, these variables should work even better.

Feedback from Joris:

On my full screen, the main text is now indeed 750px wide. On the screenshot below, I reduced my browser window width from 1900 to 1350px, and then the main content it is only 600px wide (which I personally find too narrow, if there is more space available). But at the same time, there is still non-utilized white space on both sides.
I am wondering if it is possible, at some point when the screen becomes narrower, to "just" use the full width?

Full width until width breakpoint 1300px
@choldgraf
Copy link
Collaborator

I think that this might address my issue #140 as well 👍

@hoetmaaiers
Copy link
Collaborator Author

I think that this might address my issue #140 as well 👍

Indeed, what you described in your concerns and solution is what can be done by extending the breakpoint variables. Do you think the breakpoint at width 1300px is good for your screen setup?

@choldgraf
Copy link
Collaborator

I think 1300 is reasonable? Maybe 1350? For some reason my brain thinks of "actually big screens" as starting at 1400. Maybe there is a CSS standard for this even if it's not in official bootstrap?

@jorisvandenbossche
Copy link
Member

@hoetmaaiers Thanks a lot, this looks good! (exactly what I had in mind ;))

I think the breakpoint of 1300 is OK for the current layout, in the sense that at 1300px it uses the same max-width for the main content as on wider screens.

But, there are still some things that could use more space by default:

But let's keep those for another issue/PR.

@hoetmaaiers this is ready to be merged?

@choldgraf
Copy link
Collaborator

I’d be a fan of content max width closer to 750 or 800. Usually I just do whatever google does given that they have way more UI/UX budget than I do haha. Also fine with it to be in another pr.

@hoetmaaiers
Copy link
Collaborator Author

I updated the xl breakpoint to 1400 px. Which enlarges the body content to 749. Also the TOC sidebar is again a bit wider.

From my part this is ready to be merged.

@choldgraf
Copy link
Collaborator

it looks good to me 👍

@jorisvandenbossche
Copy link
Member

Looks good, thanks for the update!

@jorisvandenbossche jorisvandenbossche merged commit 9003b4b into pydata:master Apr 6, 2020
@choldgraf
Copy link
Collaborator

woo thanks again for the nice improvement @hoetmaaiers 🎉

@hoetmaaiers hoetmaaiers deleted the feature/full-width-improvements branch April 6, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants