Skip to content

Layout is too narrow at wide screens #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
choldgraf opened this issue Apr 3, 2020 · 2 comments · Fixed by #964
Closed

Layout is too narrow at wide screens #140

choldgraf opened this issue Apr 3, 2020 · 2 comments · Fixed by #964

Comments

@choldgraf
Copy link
Collaborator

choldgraf commented Apr 3, 2020

Just wanted to share a general feeling that I've got with the new layout structure. In general I think it is an improvement, but it feels like the max-width is too small.

For example, on my laptop (not particularly big, only 13"), there is already whitespace to the left of the TOC:

image

There's whitespace on the left even though I think the page content could definitely be expanded by a decent amount more.

I think this is because (in my opinion), Bootstrap has a very conservative definition of "extra large", and we are now using a container-xl container instead of a "fluid" container for the content, so the max-width is being hit relatively early. (as an aside, Bootstrap's definition of "XL" is my definition of "medium": a 13" laptop screeen)

Is there any way that we could increase the maximum size of the content?

@jedbrown
Copy link

Is there a recommended/supported way to customize this width? The current limits are super constraining for projects that use longer lines in code blocks, leaving thousands of pixels blank on a 4k display while clipping content.

@StefanUlbrich
Copy link
Contributor

@jedbrown @choldgraf I agree that on 4K the theme is too narrow. The documentation hints at adding a custom css rule but this seems to have no effect. How would one change this value and do you think it might make sense to make this a parameter for the theme?

.bd-content {
  flex-grow: 1;
  max-width: 100%;
}

@12rambau 12rambau reopened this Aug 31, 2022
@choldgraf choldgraf changed the title The new layout feels a bit tight Layout is too narrow at wide screens Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants