Skip to content

Simplify CSS variable naming / structure #623

@12rambau

Description

@12rambau

In a recent PR (#540 (comment)) @choldgraf suggested that the number of custom variable should be reduced:

One thing I'm feeling as I just went through the codebase (and echoing @pradyunsg's thoughts): we have way too many custom-defined color variables. In a subsequent PR, I think we should just define a handful of colors (e.g. "base", "primary", "secondary", etc, and just re-use those throughout)

would you thing it would make sense to go back to what material design is suggesting ?

Note: to maintain a correct dark theme some specific variables will still be needed (on_background, on_surface, shadow) in addition to the classic one (primary, secondary etc)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions