Skip to content

coverage action needs cleanup #1818

@drammock

Description

@drammock

The problems I see so far:

  1. including coverage comment step in tests.yml breaks the publish workflow (as it's triggered on releases, not PRs, so there's no PR for it to write a comment to).

  2. There's a dedicated workflow file for the coverage comment and also a step inside tests.yml that appears to do the same thing (though their configs are not identical):

- name: Coverage comment
id: coverage_comment
uses: py-cov-action/python-coverage-comment-action@v3
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
MERGE_COVERAGE_FILES: true

These should be deduplicated.

  1. IMO, ideally the release workflow wouldn't run coverage-related steps at all (only tests).

Metadata

Metadata

Assignees

No one assigned

    Labels

    impact: block-releaseShould block a release from happening. Only use if this is a critical problem we don't want to shipkind: maintenanceImproving maintainability and reducing technical debttag: CIPull requests that update GitHub Actions code

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions