-
Notifications
You must be signed in to change notification settings - Fork 352
Closed
Labels
impact: block-releaseShould block a release from happening. Only use if this is a critical problem we don't want to shipShould block a release from happening. Only use if this is a critical problem we don't want to shipkind: maintenanceImproving maintainability and reducing technical debtImproving maintainability and reducing technical debttag: CIPull requests that update GitHub Actions codePull requests that update GitHub Actions code
Description
The problems I see so far:
-
including coverage comment step in
tests.yml
breaks thepublish
workflow (as it's triggered on releases, not PRs, so there's no PR for it to write a comment to). -
There's a dedicated workflow file for the coverage comment and also a step inside
tests.yml
that appears to do the same thing (though their configs are not identical):
pydata-sphinx-theme/.github/workflows/tests.yml
Lines 139 to 144 in 408c820
- name: Coverage comment | |
id: coverage_comment | |
uses: py-cov-action/python-coverage-comment-action@v3 | |
with: | |
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
MERGE_COVERAGE_FILES: true |
These should be deduplicated.
- IMO, ideally the
release
workflow wouldn't run coverage-related steps at all (only tests).
Metadata
Metadata
Assignees
Labels
impact: block-releaseShould block a release from happening. Only use if this is a critical problem we don't want to shipShould block a release from happening. Only use if this is a critical problem we don't want to shipkind: maintenanceImproving maintainability and reducing technical debtImproving maintainability and reducing technical debttag: CIPull requests that update GitHub Actions codePull requests that update GitHub Actions code