Consider amending “Edit this page” text

[jeanas]

The edit-this-page theme component displays the text “Edit this page”. However, in most Sphinx documentation projects, this is a bit misleading: it can be construed as “This documentation is a Wiki, use this button to edit it [and you will see your changes applied instantly without vetting, like on a Wiki]”, rather than “This documentation is hosted on GitLab/GitHub, use this link to suggest an edit and it will be reviewed by the maintainers”.

Proposed new wording: “Suggest an edit”, or “Suggest an edit to this page” (not a native English speaker, is “to” the right preposition here?).

[jeanas]

Note that for the maintainers themselves, this is wrong, but hopefully they understand what it means?

Could also be “Edit on GitLab” / “Edit on GitHub”, at least this makes it clear that you don't edit the page in place.

[drammock]

I like "suggest an edit" or "edit on GitHub" with a slight preference for the second one. @12rambau WDYT?

[12rambau]

RDT is using "edit on github/gitlab", we can move toward that depending on the specified repo in conf.py.

[trallard]

+1 - I like "Edit on ...." depending on the repo location in conf.pylike @12rambau suggests.
It helps reduce ambiguity.

[choldgraf]

+1 to edit on github/lab, but if it is not trivial to implement then just use suggest and edit

[jeanas]

OK, I'll submit a PR for "Edit on GitHub/GitLab".