Skip to content

Conversation

@Viicos
Copy link
Member

@Viicos Viicos commented Sep 12, 2024

Change Summary

Fixes #10384.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Sep 12, 2024
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 12, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9c25737
Status: ✅  Deploy successful!
Preview URL: https://8335b264.pydantic-docs.pages.dev
Branch Preview URL: https://10384.pydantic-docs.pages.dev

View logs

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 12, 2024

CodSpeed Performance Report

Merging #10391 will not alter performance

Comparing 10384 (9c25737) with main (204e109)

Summary

✅ 49 untouched benchmarks

@github-actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _model_construction.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the quick turnaround.

@sydney-runkle sydney-runkle merged commit 8b6d5fc into main Sep 12, 2024
@sydney-runkle sydney-runkle deleted the 10384 branch September 12, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes-fix Used for bugfixes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to subclass model with @computed_field(deprecated=True)

3 participants