Bugfix for cli_kebab_case="all" and CliImplicitFlag[bool] #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschwab
reviewed
Nov 25, 2025
| elif field_name.endswith(':subcommand') and val is not None: | ||
| selected_subcommands.append(self._parser_map[field_name][val].dest) | ||
| elif self.cli_kebab_case == 'all': | ||
| if isinstance(val, bool): |
Contributor
There was a problem hiding this comment.
Instead of making it specific to bool, can you update to exclude above on str. e.g.
elif self.cli_kebab_case == 'all' and isinstance(val, str):
All of the logic in this case assumes val is str. Thanks for the catch 👍🏾
Contributor
Author
There was a problem hiding this comment.
Suggested change is indeed better. When I wrote the bug fix, I didn't pay much attention to possible types of val and took the easy way out.
Contributor
|
Thanks @Digity101 for the fix! @hramezani looks good to me. |
hramezani
approved these changes
Nov 25, 2025
Member
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #701