Skip to content

Fix an issue when inner types of a discriminated union with a callable discriminator were not correctly identified as complex. #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2024
Merged

Fix an issue when inner types of a discriminated union with a callable discriminator were not correctly identified as complex. #285

merged 1 commit into from
May 3, 2024

Conversation

jenskeiner
Copy link
Contributor

@jenskeiner jenskeiner commented May 3, 2024 •
edited by hramezani
Loading

Closes #284

@jenskeiner
Fix an issue when inner types of a discriminated union with a callabl…
f1d01b2 
…e discriminator were not correctly identified as complex.
@jenskeiner jenskeiner mentioned this pull request May 3, 2024
Closed
@hramezani hramezani changed the title Fix an issue when inner types of a discriminated union with a callabl… Fix an issue when inner types of a discriminated union with a callable discriminator were not correctly identified as complex. May 3, 2024
@hramezani hramezani merged commit 8c5a45e into pydantic:main May 3, 2024
@hramezani
Copy link
Member

Thanks @jenskeiner

@renovate renovate bot mentioned this pull request Aug 31, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramezani hramezani hramezani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discriminated unions with callable discriminator don't work correctly.
2 participants
@jenskeiner @hramezani