Skip to content

Fix error when no secret file provided for a complex field. #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fix error when no secret file provided for a complex field. #118

merged 1 commit into from
Jul 10, 2023
+4 −2

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Jul 10, 2023 •
edited by pydantic-hooky bot
Loading

Closes #113

Selected Reviewer: @samuelcolvin

@hramezani hramezani mentioned this pull request Jul 10, 2023
Closed
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2303f50) 97.44% compared to head (a39f882) 97.44%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files           5        5           
  Lines         313      313           
  Branches       68       68           
=======================================
  Hits          305      305           
  Misses          6        6           
  Partials        2        2
Impacted Files Coverage Δ
pydantic_settings/sources.py 97.70% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hramezani
Copy link
Member Author

please review

@hramezani hramezani requested a review from Kludex July 10, 2023 10:24
@hramezani hramezani merged commit 14ea54c into main Jul 10, 2023
@hramezani hramezani deleted the secret_missing_complex branch July 10, 2023 13:15
@hramezani hramezani mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees

@samuelcolvin samuelcolvin

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If there is anything other than basic types (str, int etc) and secrets_dir does not include it, you get a json error
3 participants
@hramezani @Kludex @samuelcolvin