Skip to content

optimize refcounting op in datetime creation #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2024
Merged

optimize refcounting op in datetime creation #1590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/input/datetime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ pub fn pydate_as_date(py_date: &Bound<'_, PyAny>) -> PyResult<Date> {
}

impl<'py> EitherDate<'py> {
pub fn try_into_py(&self, py: Python<'py>, input: &(impl Input<'py> + ?Sized)) -> ValResult<PyObject> {
pub fn try_into_py(self, py: Python<'py>, input: &(impl Input<'py> + ?Sized)) -> ValResult<PyObject> {
match self {
Self::Raw(date) => {
if date.year == 0 {
Expand All @@ -63,7 +63,7 @@ impl<'py> EitherDate<'py> {
let py_date = PyDate::new(py, date.year.into(), date.month, date.day)?;
Ok(py_date.into())
}
Self::Py(py_date) => Ok(py_date.clone().into()),
Self::Py(py_date) => Ok(py_date.into()),
}
}

Expand Down Expand Up @@ -285,7 +285,7 @@ pub fn pydatetime_as_datetime(py_dt: &Bound<'_, PyAny>) -> PyResult<DateTime> {
}

impl<'py> EitherDateTime<'py> {
pub fn try_into_py(&self, py: Python<'py>, input: &(impl Input<'py> + ?Sized)) -> ValResult<PyObject> {
pub fn try_into_py(self, py: Python<'py>, input: &(impl Input<'py> + ?Sized)) -> ValResult<PyObject> {
match self {
Self::Raw(dt) => {
if dt.date.year == 0 {
Expand All @@ -310,7 +310,7 @@ impl<'py> EitherDateTime<'py> {
)?;
Ok(py_dt.into())
}
Self::Py(py_dt) => Ok(py_dt.clone().into()),
Self::Py(py_dt) => Ok(py_dt.into()),
}
}

Expand Down
Loading