Fix bug with running graphs in temporal workflows #3460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DouweM
reviewed
Nov 17, 2025
Docs Preview
|
DouweM
requested changes
Nov 17, 2025
|
|
||
| def _task_to_node( | ||
| self, task: EndMarker[FinalResult[OutputDataT]] | JoinItem | Sequence[GraphTask] | ||
| self, task: EndMarker[FinalResult[OutputDataT]] | JoinItem | Sequence[GraphTaskRequest] |
Collaborator
There was a problem hiding this comment.
I don't think this needed to be changed
| task_id: TaskID = field(default_factory=lambda: TaskID(str(uuid.uuid4())), repr=False) | ||
|
|
||
| @dataclass | ||
| class GraphTask(GraphTaskRequest): |
Collaborator
There was a problem hiding this comment.
Didn't you say you were going to make this not be a subclass of the other?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graphs are using
uuid.uuid4()currently which is too random for temporal.This PR changes things so we use a deterministic approach to generating task and node-run IDs, and eliminates the (essentially unused) graph run ID.
This PR also adds an example of a multi-agent graph for research that runs using temporal.