Skip to content

Conversation

@tim-x-y-z
Copy link
Contributor

@tim-x-y-z tim-x-y-z commented Feb 13, 2024

couldn't add it to the Select from react-select as it seems it doesn't support it - i get the following error message:

Property autoComplete does not exist on type
IntrinsicAttributes & Omit<PublicBaseSelectProps<unknown, boolean, GroupBase<unknown>>, StateManagedPropKeys> & Partial<...> & StateManagerAdditionalProps<...> & RefAttributes<...>

not sure what to do for that one.

should close #92

@codecov
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d3a8e6c) 95.65% compared to head (b7545cc) 95.67%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
+ Coverage   95.65%   95.67%   +0.02%     
==========================================
  Files          14       14              
  Lines         943      948       +5     
==========================================
+ Hits          902      907       +5     
  Misses         41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

# time in ms to debounce requests by, defaults to 300ms
debounce: _t.Union[int, None] = None
placeholder: _t.Union[str, None] = None
autocomplete: _t.Union[str, None] = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess remove from here if react-select doesn't support it.

@samuelcolvin samuelcolvin merged commit 9eff25a into pydantic:main Feb 14, 2024
@samuelcolvin
Copy link
Member

great, thanks so much.

@tim-x-y-z tim-x-y-z deleted the autocomplete-on-form-fields branch February 14, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

autocomplete on Forms

2 participants