Improve typing support #939
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fields and variables must have a single type declaration, fix this by moving field declarations to class level instead of on multiple branches on init
This is not technically correct because __init__ assigns None but most code relies on it being a dict. Make this change now to reduce the number of typing errors.
All supported versions have mock inside the standard library
This slightly reduces code duplication. It also fixes Queue.itervalues() constructing objects in an incorrect way as flagged by type checkers.
This is what set_config_element actually passes so this fixes a type error
|
Failure seems transient, unrelated to my change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple Changes:
mypyto the git workflow "lint" stepCurrently at <30 typing errors.
Let me know if you want this to actually reach zero mypy errors. Alternatively I can split this PR into smaller changes instead.