Skip to content

Add FreeBSD support #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Add FreeBSD support #18

merged 3 commits into from
Dec 11, 2023

Conversation

LukaszMoskala
Copy link
Contributor

Closes issue #17

Checklist

  • Pull request details were added to CHANGELOG.rst
  • Documentation was updated (if needed)

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (918d159) 98.32% compared to head (e7c358b) 98.32%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #18   +/-   ##
========================================
  Coverage    98.32%   98.32%           
========================================
  Files            2        2           
  Lines          239      239           
  Branches        62       62           
========================================
  Hits           235      235           
  Misses           2        2           
  Partials         2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhpvorderman
Copy link
Contributor

Thanks! I will merge this as soon as the tests pass.

@rhpvorderman rhpvorderman merged commit 2adcbf2 into pycompression:develop Dec 11, 2023
@gdt
Copy link

gdt commented Dec 30, 2023

Thanks for submitting and merging this! I tried to update Home Assistant to 2023.12, on NetBSD, and failed. I have not gotten around to figuring out how to fix. I just tried again with 2023.12.4, wondering if it had been addressed and was very pleasantly surprised -- the pip upgrade finished straigthforwardly and my instance is running fine.

I also wonder if the Unix (POSIX?) branch should simply be "if not windows and if not mac", rather than an explicit list, but with bsd in the code, it's working for me.

@rhpvorderman
Copy link
Contributor

There is also stuff like OS/2, android, iOS. So it has to be a little bit more explicit ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants