This repository was archived by the owner on Sep 16, 2024. It is now read-only.
main.c, sflash_diskio.c: get flash size by call to spi_flash_get_chip_size() #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of guessing it by ESP revision number. Even if the result from spi_flash_get_chip_size() could be used directly here, the same logic is used as in sflash_diskio.c to avoid inconsistencies.
Contributor
Author
|
@Xykon There are problems with integration checks since a few days: continuous-integration/jenkins/pr-head |
Contributor
Author
|
Does not work as expected. |
X-Ryl669
pushed a commit
to X-Ryl669/pycom-micropython-sigfox
that referenced
this pull request
May 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of guessing it by ESP revision number. Even if the result from spi_flash_get_chip_size() could be
used directly here, the same logic is used in sflash_diskio.c and main.c to avoid inconsistencies.
The change in sflash_diskio.c was already implemented in previous versions but got lost or was dropped intentionally.