_thread.start_new_thread fails to return to main, on start if arg list is missing

[gregcope]

MicroPython v1.8.6-849-83e2f7f on 2018-03-19; GPy with ESP32

• Exact steps to cause this issue
  Call _thread.start_new_thread with a function that takes no arguments, without supplying an empty list thus;

self.gps_thread = _thread.start_new_thread(self.feedMicroGPS)

It works if I do this;

self.gps_thread = _thread.start_new_thread(self.feedMicroGPS,())

• What you expected
  Calling a _thread.start_new_thread with a function, which takes no args, should return with new thread ID if called without any args - ie empty list should not be required.

• What happened instead
  thread starts, but never returns. Main hangs.

If it needs/expects an empty list it should throw an exception or accept no args and return. Not hang main.

[gregcope]

Is this the function that needs a tweak;

pycom-micropython-sigfox/py/modthread.c

Line 205 in 86da809

STATIC mp_obj_t mod_thread_start_new_thread(size_t n_args, const mp_obj_t *args) {

[Sympatron]

When I try to call start_new_stread() with just one argument I get the following exception:

TypeError: function missing 1 required positional arguments

Which makes sence since the following line states that at least 2 arguments are expected:

pycom-micropython-sigfox/py/modthread.c

Line 257 in 7c0b797

STATIC MP_DEFINE_CONST_FUN_OBJ_VAR_BETWEEN(mod_thread_start_new_thread_obj, 2, 3, mod_thread_start_new_thread);

Are you sure you use the latest version?

[gregcope]

Will need to check versions...