Feature: Improve Kernel Decorator #69

smazouz42 · 2024-07-23T15:01:06Z

This pull request addresses issue #68 by changing the implantation of kernel decorate, so the function runs multiple times depending on the number of blocks and the number of threads for each block

This PR aims to make the C code compilable using nvcc. The cuda language was added as well as a CudaCodePrinter. Changes to stdlib: Wrapped expressions using complex types in an `ifndef __NVCC__` to avoid processing them with the nvcc compiler --------- Co-authored-by: Mouad Elalj, EmilyBourne

This pull request fixes #48, by implementing a tiny wrapper for CUDA and a wrapper for non-CUDA functionalities only with external 'C'. **Commit Summary** - Implemented new header printer for CUDA. - Added CUDA wrapper assignment - Instead of wrapping all local headers, wrap only C functions with extern 'C' --------- Co-authored-by: EmilyBourne <[email protected]> Co-authored-by: bauom <[email protected]>

This pull request addresses issue #28 by implementing a new feature in Pyccel that allows users to define custom GPU kernels. The syntax for creating these kernels is inspired by Numba. and I also need to fix issue #45 for testing purposes **Commit Summary** - Introduced KernelCall class - Added cuda printer methods _print_KernelCall and _print_FunctionDef to generate the corresponding CUDA representation for both kernel calls and definitions - Added IndexedFunctionCall represents an indexed function call - Added CUDA module and cuda.synchronize() - Fixing a bug that I found in the header: it does not import the necessary header for the used function --------- Co-authored-by: EmilyBourne <[email protected]> Co-authored-by: bauom <[email protected]> Co-authored-by: Emily Bourne <[email protected]>

This pull request addresses issue #59 by adding more CUDA-specific keywords to enhance the checking of variable/function names and prevent name clashes --------- Co-authored-by: EmilyBourne <[email protected]> Co-authored-by: bauom <[email protected]>

This pull request addresses issue #41 by implementing a new feature in Pyccel that allows users to define a custom device **Commit Summary** - Adding handler for custom device and its code generation. - Adding test --------- Co-authored-by: EmilyBourne <[email protected]>

pyccel-bot · 2024-07-23T15:01:23Z

Hello again! Thank you for this new pull request 🤩.

Please begin by requesting your checklist using the command /bot checklist

smazouz42 · 2024-07-23T15:01:35Z

/bot run cuda

smazouz42 · 2024-07-23T15:37:29Z

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

Write a clear PR description
Add tests to check your code works as expected
Update documentation if necessary
Update Changelog
Ensure any relevant issues are linked
Ensure new tests are passing

pyccel-bot · 2024-07-23T15:42:44Z

Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready.

pyccel-bot

There seems to be lines in this PR which aren't tested. Please take a look at my comments and add tests which cover the new code.

If this is modified code which cannot be easily tested in this PR please open an issue to request that this code be either removed or tested. Once you have done that please leave a message on the relevant conversation beginning with the line /bot accept and referencing the issue.

Similarly if the new code cannot be tested for some reason, please leave a comment beginning with the line /bot accept on the relevant conversation explaining why the code can't be tested.

pyccel/decorators.py

smazouz42 · 2024-07-23T17:13:36Z

/bot run docs

smazouz42 · 2024-07-23T17:25:54Z

/bot run docs

pyccel-bot

Good job ! Your PR is using all the code it added/changed.

pyccel-bot · 2024-07-23T17:56:00Z

Hey @pyccel/pyccel-dev ! @smazouz42 has just created this great new pull request! Check it out and let me know what you think!

CHANGELOG.md

pyccel/decorators.py

pyccel-bot · 2024-07-26T13:31:05Z

Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with /bot mark as ready.

pyccel-bot

Good job ! Your PR is using all the code it added/changed.

pyccel-bot

Good job ! Your PR is using all the code it added/changed.

pyccel-bot · 2024-07-26T14:15:45Z

@EmilyBourne, @smazouz42 has been working hard and thinks that they have now replied to or fixed all your comments. Could you take another look at the PR and see if you can approve now?

tests/pyccel/scripts/kernel/hello_kernel.py

EmilyBourne

Looks good to me. This should make it much easier to test our array devs!

EmilyBourne · 2024-07-26T16:21:38Z

/bot run pr_tests

pyccel-bot

Good job ! Your PR is using all the code it added/changed.

This pull request addresses issue #68 by changing the implantation of kernel decorate, so the function runs multiple times depending on the number of blocks and the number of threads for each block --------- Co-authored-by: EmilyBourne <[email protected]> Co-authored-by: bauom <[email protected]>

EmilyBourne and others added 9 commits July 19, 2024 15:30

Trigger tests on push to devel or main branch

b9e5c94

Add cuda workflow to test cuda developments on CI

df24e81

Trigger tests on push to devel or main branch

31d7247

improve kernel decorator

e5feffb

github-actions bot marked this pull request as draft July 23, 2024 15:01

smazouz42 linked an issue Jul 23, 2024 that may be closed by this pull request

Improve kernel decorator #68

Closed

addinf doc string to all CudaThreadIndexing fucntions

2547f6e

update CHANGELOG

f80eed5

smazouz42 marked this pull request as ready for review July 23, 2024 15:40

github-actions bot marked this pull request as draft July 23, 2024 15:42

pyccel-bot bot suggested changes Jul 23, 2024

View reviewed changes

pyccel/decorators.py Outdated Show resolved Hide resolved

pyccel/decorators.py Outdated Show resolved Hide resolved

pyccel/decorators.py Outdated Show resolved Hide resolved

Add missing docstring for internal_loop in KernelAccessor class

6df004d

Add missing docstring for internal_loop in KernelAccessor class

048bd16

smazouz42 marked this pull request as ready for review July 23, 2024 17:34

pyccel-bot bot approved these changes Jul 23, 2024

View reviewed changes

pyccel-bot bot added the needs_initial_review label Jul 23, 2024

pyccel-bot bot requested a review from a team July 23, 2024 17:56

jalalium requested changes Jul 24, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

pyccel/decorators.py Outdated Show resolved Hide resolved

pyccel/decorators.py Outdated Show resolved Hide resolved

pyccel/decorators.py Outdated Show resolved Hide resolved

pyccel/decorators.py Show resolved Hide resolved

github-actions bot marked this pull request as draft July 26, 2024 13:31

pyccel-bot bot approved these changes Jul 26, 2024

View reviewed changes

smazouz42 added 3 commits July 26, 2024 14:50

fix linting

5c8fa2d

fix linting

f6a5792

fix linting

cd9ce2b

smazouz42 marked this pull request as ready for review July 26, 2024 13:55

smazouz42 mentioned this pull request Jul 26, 2024

Improve device decorator #70

Closed

pyccel-bot bot approved these changes Jul 26, 2024

View reviewed changes

pyccel-bot bot added the Ready_for_review Received at least one approval. Requires review from senior developer label Jul 26, 2024

pyccel-bot bot requested a review from EmilyBourne July 26, 2024 14:15

EmilyBourne reviewed Jul 26, 2024

View reviewed changes

tests/pyccel/scripts/kernel/hello_kernel.py Outdated Show resolved Hide resolved

.

ef09298

EmilyBourne approved these changes Jul 26, 2024

View reviewed changes

pyccel-bot bot added Ready_to_merge Approved by senior developer. Ready for final approval and merge and removed Ready_for_review Received at least one approval. Requires review from senior developer labels Jul 26, 2024

EmilyBourne enabled auto-merge (squash) July 26, 2024 14:38

pyccel-bot bot approved these changes Jul 26, 2024

View reviewed changes

EmilyBourne merged commit bf76594 into devel Jul 26, 2024

EmilyBourne deleted the issue_68 branch July 26, 2024 16:42

pyccel-bot bot added Ready_to_merge Approved by senior developer. Ready for final approval and merge and removed Ready_to_merge Approved by senior developer. Ready for final approval and merge labels Jul 26, 2024

Feature: Improve Kernel Decorator #69

Feature: Improve Kernel Decorator #69

Uh oh!

Conversation

smazouz42 commented Jul 23, 2024

Uh oh!

pyccel-bot bot commented Jul 23, 2024

Uh oh!

smazouz42 commented Jul 23, 2024

Uh oh!

smazouz42 commented Jul 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pyccel-bot bot commented Jul 23, 2024

Uh oh!

pyccel-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smazouz42 commented Jul 23, 2024

Uh oh!

smazouz42 commented Jul 23, 2024

Uh oh!

pyccel-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

pyccel-bot bot commented Jul 23, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pyccel-bot bot commented Jul 26, 2024

Uh oh!

pyccel-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

pyccel-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

pyccel-bot bot commented Jul 26, 2024

Uh oh!

Uh oh!

EmilyBourne left a comment

Choose a reason for hiding this comment

Uh oh!

EmilyBourne commented Jul 26, 2024

Uh oh!

pyccel-bot bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

smazouz42 commented Jul 23, 2024 •

edited

Loading