Skip to content

Conversation

@henryiii
Copy link
Collaborator

Description

I think it's about time for another release. I'm interested in getting a few of the build system fixes out (Windows ARM support, specifiably), and it looks like there have been some other nice fixes.

Preparing the changelog for the next release. Is there any reason to make this a minor release? Everything looks pretty safe for a patch release to me. The one large change is the Eigen one, but that's a large change to a small optional portion, and backward compatible, I think.

Signed-off-by: Henry Schreiner <[email protected]>
@rwgk
Copy link
Collaborator

rwgk commented Dec 20, 2022

The one large change is the Eigen one, but that's a large change to a small optional portion, and backward compatible, I think.

Yes, agreed. But I think it'll be best to finalize and merge #4412 before making a release, to fix the ODR issue in the test that accidentally slipped in.

@rwgk
Copy link
Collaborator

rwgk commented Dec 20, 2022

Yes, agreed. But I think it'll be best to finalize and merge #4412 before making a release, to fix the ODR issue in the test that accidentally slipped in.

I just merged #4412.

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii merged commit 3fd1520 into pybind:master Dec 20, 2022
@henryiii henryiii deleted the henryiii/chore/bumpver branch December 20, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants