Skip to content

doc + test: Using py::classh but with fallback to classic pybind11 #2952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2021
Merged

doc + test: Using py::classh but with fallback to classic pybind11 #2952

merged 2 commits into from
Apr 14, 2021

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Apr 14, 2021

No description provided.

@rwgk rwgk requested a review from henryiii as a code owner April 14, 2021 20:10
@rwgk rwgk force-pushed the test_classh_mock branch from 8186380 to d17450e Compare April 14, 2021 21:21
@rwgk
Copy link
Collaborator Author

rwgk commented Apr 14, 2021

Hi @henryiii, sorry no need to review. The request for review was auto-added. Please feel free to ignore all smart_holder PRs. I'll tag you for actual review requests.

@rwgk
Copy link
Collaborator Author

rwgk commented Apr 14, 2021

The CI is green, also with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT (#2879), except for one notorious flake. This change will get reviewed Google-internally. Merging. I'll open a new PR if there are requests for changes.

This PR also disables one CI job (Python 3.10-dev, see comment in ci.yml). I will not squash the commits.

@rwgk rwgk merged commit ab590c6 into pybind:smart_holder Apr 14, 2021
@rwgk rwgk deleted the test_classh_mock branch April 14, 2021 22:01
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Apr 14, 2021
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Apr 14, 2021
@EricCousineau-TRI EricCousineau-TRI added the smart holder See: https://github.com/pybind/pybind11/blob/smart_holder/README_smart_holder.rst label Apr 26, 2021
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii Awaiting requested review from henryiii

Assignees
No one assigned
Labels
smart holder See: https://github.com/pybind/pybind11/blob/smart_holder/README_smart_holder.rst
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwgk @EricCousineau-TRI