Add std::valaray to docs/advanced/cast/stl.rst #2547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannickJadoul
force-pushed
the
valarray-conversion-docs
branch
from
9f44491 to
38183bc
Compare
|
I'm going to merge, partially to see if the |
henryiii
approved these changes
Oct 4, 2020
|
🎉 |
|
This line might help: - any: ['include/pybind11/**/*.h', 'tools/*.cmake*', '**/CMakeLists.txt', 'pybind11/**/*.py'] |
Well, better be too careful, I'd say? Looking at a PR and removing "needs changelog" is rather painless? Anyway, great job, again! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up notifications, I came across this comment by @darkdragon-001: #545 (comment)
Bit silly in size as PR, but otherwise, we'll probably forget about it again. If necessary, I can still extend this PR by messing up some markdown and adding "an awesome project" in some places?