Fix Cygwin support #217
Merged
Fix Cygwin support #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thank you! By the way: I added a note that Cygwin is supported in README.md. Should I refer to any specific version? |
|
I'm using the latest version which is 2.5.1. But I assume that pybind11 also works fine on older versions (if not, someone will probably open a ticket :). |
|
I just saw that you added Cygwin to the list of supported compilers. This looks a bit strange to me as Cygwin isn't a compiler? But then I don't know either where to mention Cygwin (if there was a list of supported platforms, one could add it here). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to fix Cygwin support after #207 was merged.