Skip to content

[BUG] Possible issue loading pybind11 as submodule twice #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
henryiii opened this issue Jan 16, 2021 · 0 comments · Fixed by #2804
Closed

[BUG] Possible issue loading pybind11 as submodule twice #2800

henryiii opened this issue Jan 16, 2021 · 0 comments · Fixed by #2804

Comments

@henryiii
Copy link
Collaborator

henryiii commented Jan 16, 2021

This came up on the CMake issue tracker; pybind11 might not support being loaded twice. For example, if you have two submodules, and they both load pybind11, then they interfere (and, glancing at the code, I think this is will not work currently because we create the first target or two without checking for existence). To properly test, we ideally should put loads into two directories, since directory-wide variables need to be reloaded (targets should be global and should not be recreated).

Reported by @dmikushin in https://gitlab.kitware.com/cmake/cmake/-/issues/16414#note_886491

I think we support it in Config mode, but not in submodule mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant