Replace use of distutils by shutils.copytree in datasets.py #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in issue #457, the module `distutils` is deprecated since python v3.12. I believe it is only used in `datasets.py` and can be replaced with `shutils.copytree`. This PR attempts to fix the issue by replacing `distutils.dir_util.copy_tree` by `shutils.copytree`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #458 +/- ##
==========================================
- Coverage 84.24% 84.23% -0.01%
==========================================
Files 160 160
Lines 13243 13242 -1
==========================================
- Hits 11156 11155 -1
Misses 2087 2087
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dnerini
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #457, the module
distutilsis deprecated since python v3.12. I believe it is only used indatasets.pyand can be replaced withshutils.copytree.This PR attempts to fix the issue by replacing
distutils.dir_util.copy_treebyshutils.copytree.