Miscellaneous bug fixes and performance improvements #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nflict arises with one of the parent splitters
- A dumb fix that probably doesn't address the underlying issue
- Improves performance when closing multiple times (e.g. because of sloppy programming elsewhere)
- Improves performance during initialization
…se PygmentsSH - Avoids always falling back to Python lexer, even if a different extension was specified
- Don't leave lexer unset even if no mimetype has been specified
…has occurred - avoids unsaved tabs from being renamed to blank
- Improves performance
…lines - Matches expectations for working with text
…out of the viewport - Fixed line numbers when line wrapping is enabled
- Avoids lexer from being reset when original is closed
…nels as originals - This doesn't need to be the case if they are programmatically altered
- Doesn't overwrite clipboard when a non-selected full line of only whitespace is cut
- Avoids non-responsiveness when pressing enter too quickly
|
I took a look at the changes, they look very good. In your opinion, is this ready to be merged and published as 2.13.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a loose collection of bug fixes and performance improvements.
(Request: Would it be possible to merge #163, #164, and this PR, and then release it as 2.12.2?)