Skip to content

Conversation

grisaitis
Copy link
Contributor

@grisaitis grisaitis commented Aug 7, 2018

See signature of siphon.DataQuery.lonlat_box: https://github.com/Unidata/siphon/blob/a6529fbaf3165f93cdffa87080295431a647df2c/siphon/http_util.py#L174

pvlib python pull request guidelines

Thank you for your contribution to pvlib python! You may delete all of these instructions except for the list below.

You may submit a pull request with your code at any stage of completion.

The following items must be addressed before the code can be merged. Please don't hesitate to ask for help if you're unsure of how to accomplish any of the items below:

  • Closes issue ForecastModel.set_query_latlon provides arguments in the wrong order to query.lonlat_box. Longitude should precede latitude.  #521
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • N/A Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

@wholmgren
Copy link
Member

@grisaitis do you want to add your name or username to the contributors list at the bottom of the whatsnew file?

@wholmgren wholmgren added this to the 0.6.0 milestone Aug 8, 2018
@wholmgren wholmgren added the bug label Aug 8, 2018
@wholmgren wholmgren merged commit 5e6ba7e into pvlib:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants