Skip to content

Conversation

@wholmgren
Copy link
Member

@wholmgren wholmgren commented Apr 6, 2018

Will anyone miss these internal pvlib logging calls?

With these changes, grep logg pvlib/* -R returns nothing.

  • Closes logging.basicConfig in __init__.py causes misbehavior after import #447
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests must pass on the TravisCI and Appveyor testing services.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff and/or landscape.io linting service.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.

@wholmgren wholmgren added this to the 0.5.2 milestone Apr 6, 2018
@mikofski
Copy link
Member

mikofski commented Apr 6, 2018

No I won't miss them. Less to maintain if we cut them out. My vote is to approve this PR.

@cwhanse
Copy link
Member

cwhanse commented Apr 6, 2018 via email

Copy link
Contributor

@markcampanelli markcampanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@wholmgren wholmgren merged commit 23236b2 into pvlib:master Apr 9, 2018
@wholmgren wholmgren deleted the nologging branch May 19, 2018 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants