Skip to content

Conversation

@wholmgren
Copy link
Member

@wholmgren wholmgren commented Jan 23, 2018

  • Closes update for pandas 0.22 nan changes #406
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests must pass on the TravisCI and Appveyor testing services.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff and/or landscape.io linting service.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.

@wholmgren wholmgren added this to the 0.5.2 milestone Jan 23, 2018
@wholmgren wholmgren merged commit 112ee56 into pvlib:master Jan 23, 2018
@wholmgren wholmgren deleted the pandas022 branch January 23, 2018 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant