Skip to content

Conversation

@wholmgren
Copy link
Member

@wholmgren wholmgren commented Nov 1, 2017

  • Closes issue tests fail on appveyor builds #392
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests must pass on the TravisCI and Appveyor testing services.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff and/or landscape.io linting service.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.

I'll merge in a day or two if there are no suggestions/objections.

@wholmgren wholmgren added this to the 0.5.2 milestone Nov 1, 2017
@wholmgren wholmgren merged commit 1182c8e into pvlib:master Nov 6, 2017
@wholmgren wholmgren deleted the appveyor branch August 28, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant