Skip to content

Change default method in Location.get_sun_rise_set_transit #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2025
Merged

Change default method in Location.get_sun_rise_set_transit #2410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7843655
Change default method in Location.get_sun_rise_set_transit
AdamRJensen Mar 14, 2025
785da72
Update v0.11.3.rst
AdamRJensen Mar 14, 2025
7767e8c
Update docs/sphinx/source/whatsnew/v0.11.3.rst
AdamRJensen Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/sphinx/source/whatsnew/v0.11.3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ Breaking Changes
Use :py:func:`~pvlib.spectrum.spectral_factor_firstsolar` instead. (:issue:`2130`, :pull:`2131`)
* Remove deprecated :py:func:`!pvlib.spectrum.get_am15g` function; use
:py:func:`~pvlib.spectrum.get_reference_spectra` instead. (:pull:`2409`)
* Change default method of :py:func:`~pvlib.location.Location.get_sun_rise_set_transit`
to ``'spa'`` instead of ``'pyephem'``. (:pull:`2410`)

Bug fixes
~~~~~~~~~
Expand Down
4 changes: 2 additions & 2 deletions pvlib/location.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,15 +368,15 @@ def get_airmass(self, times=None, solar_position=None,

return airmass

def get_sun_rise_set_transit(self, times, method='pyephem', **kwargs):
def get_sun_rise_set_transit(self, times, method='spa', **kwargs):
"""
Calculate sunrise, sunset and transit times.

Parameters
----------
times : DatetimeIndex
Must be localized to the Location
method : str, default 'pyephem'
method : str, default 'spa'
'pyephem', 'spa', or 'geometric'

kwargs :
Expand Down