Skip to content

Conversation

BernatNicolau
Copy link
Contributor

@BernatNicolau BernatNicolau commented Aug 26, 2024

@BernatNicolau
Copy link
Contributor Author

The issue has been resolved here

@kandersolar kandersolar added this to the v0.11.1 milestone Aug 28, 2024
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @BernatNicolau!

Also, just FYI: it looks like your local git client is configured to make commits with a different user from the one you're using to submit PRs.

@kandersolar kandersolar merged commit aaf42f6 into pvlib:main Aug 28, 2024
31 checks passed
@BernatNicolau BernatNicolau deleted the issue_2158 branch August 28, 2024 11:10
@BernatNicolau
Copy link
Contributor Author

LGTM, thanks @BernatNicolau!

Also, just FYI: it looks like your local git client is configured to make commits with a different user from the one you're using to submit PRs.

Yes, I think I fixed that yesterday 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change axis start in single diode IV curve example
3 participants