pvsystem.singlediode
with method='newton'
can be passed pd.Series
of length one.
#1822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Updates entries indocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.The cause of the issue is that pandas.Series of length one cannot be converted to bool values. When pandas.Series of length one are passed to bishop88, the newton solver attempts that conversion here.
Also,
reimplemented singlediode._get_size_and_shape
and named itsinglediode._shape_of_max_size
.singlediode._prepare_newton_inputs
,pvsystem.i_from_v
, andpvsystem.v_from_i
usedsinglediode._get_size_and_shape
, so they have been updated too.pvsystem.i_from_v
, andpvsystem.v_from_i
logic for choosing the correct output shape is now similar to the logic insinglediode._lambertw_i_from_v
.