Clarify PVWatts DC and inverter documentation #1785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandersolar
approved these changes
Jun 27, 2023
| @@ -393,6 +397,7 @@ def pvwatts(pdc, pdc0, eta_inv_nom=0.96, eta_inv_ref=0.9637): | |||
| pdc_neq_0 = ~np.equal(pdc, 0) | |||
|
|
|||
| # eta < 0 if zeta < 0.006. power_ac is forced to be >= 0 below. GH 541 | |||
| # differs from Eq. 10 of [1], where parentheses were omitted by mistake | |||
| eta = eta_inv_nom / eta_inv_ref * ( | |||
| -0.0162 * zeta - np.divide(0.0059, zeta, out=eta, where=pdc_neq_0) | |||
| + 0.9858) # noQA: W503 | |||
There was a problem hiding this comment.
What's the difference between this code and the equation in the reference? I can't see it:
There was a problem hiding this comment.
The parentheses are missing in this copy: https://www.nrel.gov/docs/fy14osti/62641.pdf Which copy did you open?
There was a problem hiding this comment.
Oh interesting. I was looking at the PDF linked in the pvlib.inverter.pvwatts docstring: https://pvwatts.nrel.gov/downloads/pvwattsv5.pdf
Good to know there are multiple non-identical versions of that PDF. I wonder if there are any other differences...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxx[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.[ ] Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Email exchange with a user pointed out a possible ambiguity with
pvsystem.pvwatts_dcandinverter.pvwatts- neither function provides a unit for the output DC power, or for the input DC power for the inverter.