Skip to content

Add bhi, pressure, and wind_ to list of variables #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Add bhi, pressure, and wind_ to list of variables #1247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pvlib/data/variables_style_rules.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ longitude;longitude
dni;direct normal irradiance
dni_extra;direct normal irradiance at top of atmosphere (extraterrestrial)
dhi;diffuse horizontal irradiance
bhi;beam/direct horizontal irradiance
ghi;global horizontal irradiance
aoi;angle of incidence between :math:`90\deg` and :math:`90\deg`
aoi_projection;cos(aoi)
Expand All @@ -27,6 +28,9 @@ temp_module;temperature of the module
temp_air;temperature of the air
temp_dew;dewpoint temperature
relative_humidity;relative humidity
wind_speed;wind speed
wind_direction;wind direction
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document the angle convention like we do for solar_azimuth, e.g. degrees East of North?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed, but, this is primarily a list of terms and (where needed) definitions. It seems better to leave units, angle conventions and limits to the function docstrings.

pressure;atmospheric pressure
v_mp, i_mp, p_mp;module voltage, current, power at the maximum power point
v_oc;open circuit module voltage
i_sc;short circuit module current
Expand Down