Add bhi, pressure, and wind_ to list of variables #1247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the terms except bhi are in agreement with pv-terms.
kandersolar
reviewed
Jun 21, 2021
| @@ -27,6 +28,9 @@ temp_module;temperature of the module | |||
| temp_air;temperature of the air | |||
| temp_dew;dewpoint temperature | |||
| relative_humidity;relative humidity | |||
| wind_speed;wind speed | |||
| wind_direction;wind direction | |||
There was a problem hiding this comment.
Should we document the angle convention like we do for solar_azimuth, e.g. degrees East of North?
There was a problem hiding this comment.
I'm not opposed, but, this is primarily a list of terms and (where needed) definitions. It seems better to leave units, angle conventions and limits to the function docstrings.
wholmgren
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the terms except bhi are in agreement with pv-terms.
The BHI (Beam Horizontal Irradiance) term was introduced in the variable map for the
get_camsandread_camsfunctions in #1175